Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor fee-related types #3121

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Oct 17, 2024

What ❔

  • Moves basic logic for fee types close to the type declaration (i.e., to zksync_types).
  • Unifies PubdataSendingMode and PubdataDA.
  • Removes dependency of zksync_types on zksync_config.

Why ❔

This allows external apps depending on fee types (e.g., the test node) to not have behemoths like zksync_dal in their dependency graph.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@slowli slowli added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit cfbcc11 Oct 21, 2024
46 checks passed
@slowli slowli deleted the aov-pla-1051-refactor-fee-related-types branch October 21, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants